Hartmut Goebel <h.goe...@crazy-compilers.com> skribis:
> Fixes <http://bugs.gnu.org/15890>.
>
> * nix/libstore/globals.hh (Settings) Add clientUid and clientGid.
> * nix/nix-daemon/nix-daemon.cc (daemonLoop] Store UID and GID of the
> caller in settings.
> * nix/libstore/build.cc (_chown): New function.
> (DerivationGoal::deleteTmpDir): Use it, change ownership of build
> directory if it is kept and the new owner is not root.
[...]
> +static void _chown(const Path & path, uid_t uid, gid_t gid)
> +{
> + checkInterrupt();
> +
> + printMsg(lvlVomit, format("%1%") % path);
Please remove this line (we wouldn’t be able to track where the message
comes from).
> + /* User and groud id of the client issuing the buld request. Used to set
^^
Typo. Also:
… issuing the build request, or -1 if the UID and GID are not known.
> + the owner and group of the keept temporary directories of failed
^^
Typo.
If you have checked that it works as intended, please push with these
changes and email the commit ID to 15890-d...@debbugs.gnu.org.
Thank you!
Ludo’.
