On 2016-11-18 21:10, Leo Famulari wrote:
On Wed, Nov 16, 2016 at 01:37:04AM +0100, Petter wrote:
I have worked through the issues you brought up, and it should at
least be
better now. Maybe even good.
It was already good, now it's very good :)
There is no indication of GPL v2 or later in the project though.
Okay.
Pushed as 01278f16a9b with the following two changes:
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin")))
+ (mkdir-p bin)
+ (install-file "xcalib" bin))))
(install-file) does (mkdir-p) itself, so I removed the redundant
(mkdir-p). It's defined in (guix build utils) if you are interested to
see.
Ok. I looked it up in another package, and copied the approach. (I see
this redundancy occurs in several other places.)
+ (add-after 'install 'install-doc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((doc (string-append(assoc-ref outputs
"out")
+ "/share/doc/")))
^
I added "xcalib" to the end of the path here -----------------|
So, when a user installs xcalib into their profile, the README will be
at ~/.guix-profile/share/doc/xcalib/README, instead of
~/.guix-profile/share/doc/README.
Aha. So that's how it will be used :)
Thanks for doing the final touches! And I really appreciate your
detailed explanations! The next patch should hopefully be less of a
burden on you reviewers :)
