Ricardo Wurmus writes:
> Roel Janssen <r...@gnu.org> writes:
>
>> Ricardo Wurmus writes:
>>
>>> * gnu/packages/python.scm (python-ipython): Update to 4.0.0.
>>> [inputs]: Keep only "readline" and "which"; move the remaining inputs
>>> to propagated-inputs, except for "python-requests" and "python-nose"
>>> which are moved to native-inputs.
>>> [propagated-inputs]: Add python-pexpect, python-pickleshare,
>>> python-simplegeneric, python-traitlets, python-ipykernel.
>>> [native-inputs]: Add "python-testpath".
>>> [arguments]: Enable building of HTML documentation.
>
> I noticed that I also needed to delete the patch and report it here.
> Also fixed the indentation.
>
>>> + (inputs
>>> + `(("readline" ,readline)
>>> + ("which" ,which)))
>>
>> I think it really is necessary to propagate these, isn't it?
>
> Neither of these need propagation. “readline” is checked for by
> setup.py, and for “which” we have a build phase to embed the reference
> to the “which” executable.
>
>>> (native-inputs
>>> `(("pkg-config" ,pkg-config)
>>> + ("python-requests" ,python-requests) ;; for tests
>>> + ("python-testpath" ,python-testpath)
>>> + ("python-nose" ,python-nose)
>>> ("python-sphinx" ,python-sphinx)
>>> ("texlive" ,texlive)
>>> ("texinfo" ,texinfo)
>>> @@ -4674,13 +4678,13 @@ tools for mocking system commands and recording
>>> calls to those.")
>>> (examples (string-append doc "/examples")))
>>> (setenv "LANG" "en_US.utf8")
>>> (with-directory-excursion "docs"
>>> - ;; FIXME: html and pdf fail to build
>>> - ;; (system* "make" "html")
>>> - ;; (system* "make" "pdf" "PAPER=a4")
>>> + ;; FIXME: pdf fails to build
>>> + ;;(system* "make" "pdf" "PAPER=a4")
>>> + (system* "make" "html")
>>
>> The last line isn't absolutely necessary to, but I it doesn't really
>> matter and I see why you'd want to not have a space there.
>> Nevertheless, you could shorten the patch by two lines if you feel like
>> doing so.. :)
>
> Are you saying that “make html” isn’t needed to build the html docs? I
> think it is.
No! Sorry for the confusion, it isn't the last line I meant.. If you
would leave:
;; (system* "make" "pdf" "PAPER=a4")
like that, it saves two lines in the patch.
Kind regards,
Roel Janssen
