Efraim Flashner writes:
> I don't java, so I haven't tried it out, so my comments are mostly
> cosmetic on the package definition.
>
> On Mon, Oct 24, 2016 at 04:12:25PM +0300, Theodoros Foradis wrote:
>> +
>> +(define-public plantuml
>> + (package
>> + (name "plantuml")
>> + (version "8048")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append
>> +
>> "https://downloads.sourceforge.net/project/plantuml/plantuml-";
>> + version ".tar.gz"))
>
> this should be of the mirror://sourceforge type
>
fixed
>> + (sha256
>> + (base32
>> + "1vipxd6p7isb1k1qqh4hrpfcj27hx1nll2yp0rfwpvps1w2d936i"))))
>> + (build-system ant-build-system)
>> + (arguments
>> + `(#:tests? #f ; no tests
>> + #:build-target "dist"
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-before 'build 'delete-extra-from-cp
>> + (lambda _
>> + (substitute* "build.xml"
>> + (("1.6") "1.7"))
>> + (substitute* "build.xml"
>> + (("<attribute name=\"Class-Path\"") "<!--"))
>> + (substitute* "build.xml"
>> + (("j2v8_macosx_x86_64-3.1.7.jar\" />") "-->"))))
>
> return #t
> also, since they're all for the same set (build.xml),
> you can take out the duplicate substitute* lines
>
done
>> + (add-before 'install 'gen-install
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (mkdir-p "build/jar")
>> + (system* "mv" "plantuml.jar" "build/jar")
>> + ((@@ (guix build ant-build-system) default-build.xml)
>> + "plantuml.jar"
>> + (string-append (assoc-ref outputs "out")
>> + "/share/java"))))
>> + (add-after 'install 'make-wrapper
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (wrapper (string-append out "/bin/plantuml")))
>> + (mkdir-p (string-append out "/bin"))
>> + (with-output-to-file wrapper
>> + (lambda _
>> + (display
>> + (string-append
>> + "#!" (assoc-ref inputs "bash") "/bin/sh\n\n"
>> + (assoc-ref inputs "jre") "/bin/java -jar "
>> + out "/share/java/plantuml.jar \"$@\"\n"))))
>> + (chmod wrapper #o555)))))))
>> + (inputs
>> + `(("graphviz" ,graphviz)
>> + ("bash" ,bash)
>> + ("jre" ,icedtea "out")))
>> + (home-page "http://plantuml.com/";)
>> + (synopsis "Draw UML diagrams from simple textual description")
>> + (description
>> + "Plantuml is a tool to generate sequence, usecase, class, activity,
>> +component, state, deployment and object UML diagrams, using a simple and
>> +human readable text description. Contains salt, a tool that can design
>> simple
>> +graphical interfaces.")
>> + (license license:gpl3+)))
>> --
>> 2.10.1
>>
>>
Also, I took Marius Bakke's advice, and added it to "uml.scm" instead.
Thanks for your input.
--
Theodoros Foradis
