Hello Dadiv,
I am posting a version 2 of the patch series, making the changes you suggested
for hidapi plus the following.
The git commit was changed to a more recent one. A guix package revision
was added, for future package updates.
David Craven writes:
> Hi Theodoros,
>
> Do we really need this patch? Is there a reason why it hasn't been
> upstreamed yet?
>
I updated the patch for nrf52 support, to the version which has been
tested, and is reviewd to go in master as well. Additional info, in
the patch header.
This patch is not needed for openocd to work. It adds support for a
board I am using, and since it's been tested, I think it's nice to have
in guix.
> (add-before 'configure 'bootstrap
> + (lambda _
> + (system* "aclocal")
> + (system* "libtoolize" "--automake" "--copy")
> + (system* "autoconf")
> + (system* "autoheader")
> + (system* "automake" "--gnu" "--add-missing" "--copy")
> + #t))
>
> Why not (add-before 'configure 'autoreconf
> (lambda _
> (zero? (system* "autoreconf" "-vfi"))
>
fixed
> I prefer indenting like this as is done in most of the codebase:
>
> + (inputs
> `(("libusb" ,libusb)
> + ("libusb-compat" ,libusb-compat)
> + ("libftdi" ,libftdi)
> + ("hidapi" ,hidapi)))
> + (native-inputs
> `(("autoconf" ,autoconf)
> + ("libtool" ,libtool)
> + ("automake" ,automake)
> + ("pkg-config" ,pkg-config)))
>
fixed
> It would also be nice if the inputs where ordered alphabetically.
>
done
> Thanks for the patch, looking good!! You don't need to resubmit
> (unless someone else has more objections :).
>
> David
Thanks for your input.
Theodoros Foradis (3):
gnu: Add gdb-arm-none-eabi.
gnu: Add hidapi.
gnu: Add openocd.
gnu/local.mk | 2 +
gnu/packages/embedded.scm | 83 +++++++++
gnu/packages/hidapi.scm | 63 +++++++
gnu/packages/patches/openocd-nrf52.patch | 843
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 991 insertions(+)
--
Theodoros Foradis
