Federico Beffa <be...@ieee.org> skribis:
> From 46bd8735643b50c9c13ebce595943ad20aa1c7f1 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <be...@fbengineering.ch>
> Date: Thu, 20 Oct 2016 20:23:11 +0200
> Subject: [PATCH 3/3] gnu: haskell-mode: Update to 16.1.
>
> * gnu/packages/emacs.scm (haskell-mode): Update to 16.1.
> [inputs]: Add 'emacs-el-search' and 'emacs-stream'.
> [propagated-inputs]: Add 'emacs-dash'.
> [arguments]: Add modules. Adapt 'pre-build' and 'install' phases.
[...]
> + (inputs
> + `(("emacs-el-search" ,emacs-el-search)
> + ("emacs-stream" ,emacs-stream)))
So these are only used at build time? Might be worth adding a comment
to make it clear why they are not propagated.
> (let ((sh (string-append (assoc-ref inputs "bash") "/bin/sh")))
> (setenv "SHELL" "sh")
> + (setenv "EMACSLOADPATH"
> + (apply string-append
> + (map (match-lambda
> + (((? (lambda (n)
> + (string-prefix? "emacs-" n)) name)
> + . dir)
> + (string-append (el-dir dir) ":"))
For readability, I’d suggest moving the lambda just below the ‘let’ and
giving it a name:
(define emacs-prefix?
(cut string-prefix "emacs-" <>))
Also, (string-concatenate …) instead of (apply string-append …).
OK with these changes, thanks!
Ludo’.
