Hi!

Marius Bakke <mba...@fastmail.com> skribis:

> * gnu/packages/serialization.scm (avro-version): New variable (private).
> (avro-source): New variable (private).
> (python-avro, python2-avro): New variables.

[...]

> +;;; Avro uses a single source repository for all implementations. The 
> individual
> +;;; released versions often have missing or incomplete test data, so we 
> define
> +;;; the common source here for use in all avro packages.

Two semicolons please.  :-)

> +(define-public python2-avro
> +  (let ((base (package-with-python2 (strip-python2-variant python-avro))))
> +    (package (inherit base)
> +             (arguments
> +              `(#:tests? #f ; Requires Apache Ivy.
> +                #:python ,python-2 ; Needed when overriding inherited args.
> +                #:phases
> +                (modify-phases %standard-phases
> +                  (add-after 'unpack 'enter-source
> +                    (lambda _ (chdir "lang/py") #t))))))))

Rather:

  (package
    (inherit base)
    (arguments
      (substitute-keyword-arguments (package-arguments python-avro)
        ((#:phases _)
         `(modify-phases %standard-phases
            (add-after 'unpack 'enter-source …))))))


OK with this change, thanks!

Ludo’.

Reply via email to