Ludovic Courtès <l...@gnu.org> writes:
> David Craven <da...@craven.ch> skribis:
>
>> * gnu/packages/rust.scm (rustc-bootstrap, rust-bootstrap-x86_64-1.12.0):
>> New variables.
>
> I believe this is a followup to my comments at
> <https://lists.gnu.org/archive/html/guix-devel/2016-09/msg01993.html>,
> right?
>
>> +;;; Copyright © 2016 David Craven <da...@craven.ch>
>
> And Eric Le Bihan? Or is this independent from Eric’s patch?
>
>> +(define rust-bootstrap-x86_64-1.12.0
>
> Add a comment saying that this is a pre-built binary.
>
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://static.rust-lang.org/dist/";
>> + "rust-beta-x86_64-unknown-linux-gnu.tar.gz"))
>
> This URL is unversioned, so the contents might change over time no?
I don't know what rust-beta-* is, but the rust package I created did not
use unversioned files. There are versioned files, but afaik not in
beta. For bootstrap I had this (though it could be that this is already
Jelle's work based on my work):
(define (archive-name version platform checksum)
(string-append "rust-stage0-" version "-" platform "-" checksum ".tar.bz2"))
(define rust-stage0-bootstrap-x86_64-archive
(archive-name "2016-02-17-4d3eebf" "linux-x86_64"
"d29b7607d13d64078b6324aec82926fb493f59ba"))
(define rust-stage0-bootstrap-x86_64
(origin
(method url-fetch)
(uri
(string-append "https://static.rust-lang.org/stage0-snapshots/";
rust-stage0-bootstrap-x86_64-archive))
(sha256
(base32
"0gk87rknijyirlhw3h34bjxzq98j0v0icp3l8flrxn5pgil8pswd"))))
(define rust-stage0-bootstrap-i386-archive
(archive-name "2016-02-17-4d3eebf" "linux-i386"
"5f194aa7628c0703f0fd48adc4ec7f3cc64b98c7"))
(define rust-stage0-bootstrap-i386
(origin
(method url-fetch)
(uri
(string-append "https://static.rust-lang.org/stage0-snapshots/";
rust-stage0-bootstrap-i386-archive))
(sha256
(base32
"16fd2hmli86g1q3fyicdhh2l4aqryzxcij7sk1pljig8dr2m8hg5"))))
>> + ;; Rust requires a gcc toolchain for linking. It
>> + ;; looks for a compiler named cc in it's path. This
>> + ;; can probably be configured during the build.
>
> s/This can…/Thus, add a ‘cc’ symlink next to it./
>
>> + (home-page "https://www.rust-lang.org";)
>> + (synopsis "Rustc bootstrap")
>
> “Rust bootstrapping compiler”?
>
>> + (description "This package prepares the rustc binary for bootstrapping
>> +the rustc package.")
>
> “This package provides a pre-built @command{rustc} compiler, which can
> in turn be used to build the final Rust compiler.”
>
> Thanks,
> Ludo’.
>
>
--
