Hi, Thanks for reviewing.
Leo Famulari <l...@famulari.name> writes: > [ Unknown signature status ] > On Fri, Sep 16, 2016 at 10:50:09AM +0000, ng0 wrote: >> Subject: [PATCH 1/4] gnu: Add libkqueue. >> >> * gnu/local.mk: Include gnu/packages/libdispatch.scm . >> * gnu/packages/libdispatch.scm: Add new file. >> * gnu/packages/libdispatch.scm (libkqueue): New variable. > > LGTM > >> Subject: [PATCH 2/4] gnu: Add libpthread_workqueue. >> >> * gnu/packages/libdispatch.scm (libpthread_workqueue): New variable. > >> + (version "0.9.1") > > 0.9.2 is available upstream: > https://github.com/mheily/libpwq/releases > > Can you try using that? Okay, will try it in the couple of next weeks. >> Subject: [PATCH 3/4] gnu: Add libblocks-runtime. >> >> * gnu/packages/libdispatch.scm (libblocks-runtime): New variable. > >> + (add-after 'unpack 'autogen >> + (lambda _ >> + (zero? (system* "autoreconf" "--install" "--symlink" >> "--verbose"))))))) > > Why use --symlink? I think, though I'm not sure currently as I can't keep all the unimportant details of packages in memory all the time, that if you don't provide --symlink they are statically linked. >> Subject: [PATCH 4/4] gnu: Add libdispatch. >> >> * gnu/packages/libdispatch.scm (libdispatch): New variable. > >> + (arguments >> + `(#:tests? #f)) > > The tests can be run with `ctest` [0]. > > The test suite can be built by setting "-DDISPATCH_ENABLE_TEST_SUITE=1" > in #:configure-flags. However, when I tried that, the build log included > "No compiler support for Blocks; test suite will not be built.", and the > tests were indeed not built. > > Does that mean that libblocks-runtime is not working? I think either Debian or Gentoo (if not portage, then gpo.zugaina.org) had more on this. It should work. > Also, the libdispatch tarball bundles Click [0] at 'thirdparty/click'. We > should remove that and use our Click package. > > [0] > https://github.com/nickhutchinson/libdispatch#testing-with-ctest > > [1] > http://click.pocoo.org/5/ I will focus on gnunet-service and psyced-service this month. Thanks for pointing out what you found. I can't address this immediately, could be that there'll be a delay until I'm finished with both services.
