> I tested the patches again, and they are working correctly after the fix in
> libftdi. Should we still delete "-I/usr/local/include" from the makefile
> of icestorm to ensure it doesn't build wrongly in non-guixsd systems or is
> it unnecessary?
Yes. I'm sorry, I thought I added the part removing that - but apparently not.
It can be added when merging or I or anyone else can send an updated patchset -
whichever we prefer. The change would be:
(substitute* "iceprog/Makefile"
(("-I/usr/local/include") "") ; added
(("-L/usr/local/lib") ""))))
Should we have a phase checking that in Guix in the future (which just does
"grep -r /usr ." in the package)? Maybe overkill but it would catch something
like this automatically.
> Gtkwave is fine as well. Maybe we would like to add it in
> another file though (e.g. engineering.scm), in case it's used with
> other packages in the future.
engineering.scm would be good to use for all FPGA tools. On the other hand, now
you have all the packages for FPGA development in one place - which isn't bad
either.
I guess putting just gtkwave there would be good. In any case, I don't have a
preference because I don't use the categories for anything as a user anymore.
