Marius, On 14/09/16 15:45, Marius Bakke wrote: > It's not visible in the cgit interface, but it actually seems to > support normal snapshot downloads: > https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.gz
I did not know that. Thanks for the tip! It still requires a snippet, unfortunately. > Tobias Geerinckx-Rice <m...@tobias.gr> writes: >> + #:tests? #f)) ; tests must be run as >> root > Does all tests have to run as root? Yes. Each test wants to load modules & inject synthetic MCE events. The daemon will even fail to start on an unsupported CPU like my current AMD laptop. > Also, could you reverse the order of the arguments to match other > package definitions? Hm: *some* other. I rather keep them in approximate order of use. Unrelated: I see the ‘arguments‘ indentation went funky. Will fix. >> + (home-page "http://mcelog.org/";) > Nit-pick: the trailing slash is unnecessary :) Oh, I know, I just have a thing for proper root paths in URIs. I'm seeing someone about that. >> + (synopsis "Machine check monitor for x86 Linux systems") > If this is x86-only, perhaps we should set (supported-systems)? Indeed. Thanks! Kind regards, T G-R
signature.asc
Description: OpenPGP digital signature
