Hi Ricardo,
On Thu, 01 Sep 2016 16:57:32 +0200
Ricardo Wurmus <rek...@elephly.net> wrote:
>> > + (substitute* "bin/ard-reset-arduino"
>> > + (("#!/usr/bin/env python") "#!/usr/bin/python3"))
>>
> >> This looks unnecessary. When “python-wrapper” is among the inputs the
> >> shebang would be replaced automatically.
... with Python 3's name. So okay, I'll remove this part. (I still don't get
what Guix does (not do) with major versions - but fine)
ard-reset-arduino source code should have specified which Python version it
expects in the shebang to begin with, I was just bugfixing it...
> “#!/gnu/store/…-python-3…/bin/python”. There’s nothing ambiguous about
^ yeah, I've checked out python-wrapper now and as
long as it does that now and in the future, okay :)
> We prefer to use a properly bound “inputs” over the magical
> “%build-inputs”. “%build-inputs” can be used in the specification of
> #:make-flags where “inputs” cannot be bound.
Ok.
> Then shouldn’t the inputs be propagated? As the build artifacts of this
> package retain no reference to these regular inputs it’s almost the same
> as not specifying them in the first place.
I don't know about this. I thought propagated meant that if I installed
arduino-makefile into the profile it would also install avrdude into the
profile. That is not what I wanted. The Makefile refers to the
/gnu/store/....avrdude... - that's it. But we can also propagate - I'm just not
sure whether that's needed and useful.
> This is not what “supported-systems” is used for. This field is used to
> tell the build machines in the build farm not to bother building
> packages that are not supported on the current architecture.
Ah okay. I'll remove it then.
Cheers,
Danny
