On Tue, Aug 16, 2016 at 10:21:15PM +0200, Danny Milosavljevic wrote: > gnu: python: Add python-lirc. > > * gnu/packages/python.scm (python-lirc, python2-lirc): New variables.
Can you put it in the lirc module? > +(define-public python-lirc > + (let ((commit "4091fe918f3eed2513dad008828565cace408d2f")) > + (package > + (name "python-lirc") > + (version (string-append "1.2.1-" (string-take commit 7))) Please add a package revision counter as shown in the manual section 7.6.3 Version Numbers. https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers LGTM with these changes. By the way, I looked at the Git log and so I know that you have been working on this software upstream. That's cool :) But, in general, when sending patches, please give an explanation of why we should build from a Git commit instead of the latest release tag. Because we are always going to ask and it slows down the review process.
