David Craven (2016-08-16 21:39 +0300) wrote:
> * gnu/packages/kde-frameworks.scm (networkmanager-qt)
> [propagated-inputs]: Add NETWORK-MANAGER.
> [inputs]: Remove NETWORK-MANAGER.
I would write 'network-manager' instead of NETWORK-MANAGER.
Also there should be a reason for propagating (probably written as a
comment). Ideally it should be avoided.
> ---
> gnu/packages/kde-frameworks.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index dbec5a3..61ed4aa 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -934,9 +934,10 @@ messages.")
> `(("extra-cmake-modules" ,extra-cmake-modules)
> ("dbus" ,dbus)
> ("pkg-config" ,pkg-config)))
> + (propagated-inputs
> + `(("network-manager", network-manager)))
↑↑
BTW please fix the comma placement here:
↓↓
`(("network-manager" ,network-manager)))
> (inputs
> - `(("network-manager", network-manager)
> - ("qtbase" ,qtbase)))
> + `(("qtbase" ,qtbase)))
> (arguments
> `(#:phases
> (modify-phases %standard-phases
--
Alex
