Kei Kebreau <k...@openmailbox.org> writes: > Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> writes: > >> Hi Kei, >> >>> This patch should install p7zip correctly on every architecture >>> supported by Guix. Ideally, this should be tested it on each arch for >>> the sake of completeness and safety. I've got x86_64 covered so far. :-) >> >> thank you for this patch! >> >> I see that you took care of removing non-free parts in a patch and a >> build phase. Since “guix build -S p7zip” doesn’t run the build phase >> users would still end up with a source archive containing the non-free >> parts. The best way is thus to remove things in a snippet. >> >> In “shogun” from the “machine-learning” module we remove supporting code >> for non-free features in a snippet by cutting out anything between some >> ifdef markers, but looking at the patch I see that it wouldn’t be >> feasible for p7zip. >> > > Perhaps I can just clear the non-free files and add that to the patch?
Never mind, I read your email incorrectly. After looking at many of the snippets in the Guix tree, I agree that the equivalent for p7zip would be quite large and unwieldy. Perhaps there is pre-sanitized p7zip code to pull from if a patch can't be used?
signature.asc
Description: PGP signature
