Hi Tobias,
l...@gnu.org (Ludovic Courtès) skribis:
> Tobias Geerinckx-Rice <m...@tobias.gr> skribis:
>
>> On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
>>> + (native-inputs
>>> + `(,@(if (string-prefix? "i686" (or (%current-target-system)
>>> + (%current-system)))
>>> + `(("nasm" ,nasm))
>>> + '())
>>
>> Hmm. Not sure where this falls on the ‘let the code speak for itself’
>> to ‘should have added a comment’ scale.
>>
>> Guess I'll wait for another review + patch or a very friendly committer.
>
> I have another idea: could you create a Savannah account and tell me
> your user name? :-)
I’ve added you to the Savannah group so you can commit directly.
Please see the ‘HACKING’ file on how to be a good citizen. ;-)
In particular, make sure to configure commit signing as noted at
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#16>.
So I think the last iteration of this patch, with a comment regarding
the i686 case as you wrote above, will be a good thing to push.
Happy hacking!
Ludo’.
