John J Foerch <jjfoe...@earthlink.net> writes: > Leo Famulari <l...@famulari.name> writes: > >> On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote: >>> * gnu/packages/admin.scm (di): New variable. >> >> A few final nitpicks before others make a decision about the test suite >> ;) >> >>> + (arguments >>> + `(#:phases >>> + (modify-phases %standard-phases >>> + (delete 'configure) >>> + (delete 'check) >> >> We prefer to use #:tests? #f instead of deleting the check phase. >> >>> + (add-before 'build 'setup-environment >>> + (lambda* (#:key outputs #:allow-other-keys) >>> + (setenv "CC" "gcc") >>> + (setenv "prefix" (assoc-ref outputs "out")) >>> + #t))) >>> + #:make-flags (list "-e"))) >> >> I would like for '-e' to be expanded to '--environment-overrides'. It >> seems that Schemers abhor abbreviations. >> >> Sorry for not mentioning these before. I can do them myself when pushing >> if there are no other changes to be made. > > Sounds good. Thanks.
Any remaining blocking issues on this? -- John Foerch
