Thank you for your review! Leo Famulari <l...@famulari.name> writes:
> On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: >> >> Hi Guix, >> >> Attached is a patch for LibIAX, a library that is used by the Ring >> (formerly SFLphone). > > Cool! > >> Upstream seems to use no version numbers. I used the git commit ID that >> is also refered to in the version that is bundeled with Ring. This is >> also the latest commit to libiax. > > Since there are no upstream versions, I think the version string should > use 0.0.0 to refer to the upstream version, then the Guix package > revision number, and then the 7 characters of the commit. > > So, it would end up like this: 0.0.0-1.cabba9e > > See here: > https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers OK, Thank you for pointing this out! I missed that in the manual. I updated the patch accordingly and will send it soon. > >> + (package >> + (name "libiax") >> + (version (string-append "2-" (string-take commit 7))) > > By the way, what does the "2-" refer to? Upstream seems to refer to the software as "iax" "libiax" and "libiax2" interchangeably. The "2" was the closest thing I could find to a version number. Thank you!
