On Sun, May 01, 2016 at 08:07:56PM +0300, Manolis Ragkousis wrote:
?????????????????? Jan,
On 04/29/2016 06:12 PM, Jan Nieuwenhuizen wrote:
> + #:use-module (guix build-system trivial)
> + #:export (glibc
> + libiconv-if-needed))
The #:export (glibc...) part only exists in wip-hurd so we need to
remove this in order for your patch to apply on master.
> +(define-public libiconv
> + (package
> + (name "libiconv")
> + (version "1.14")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://gnu/libiconv/libiconv-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "04q6lgl3kglmmhw59igq1n7v3rp1rpkypl366cy1k1yn2znlvckj"))))
> + (build-system gnu-build-system)
> + (synopsis "Character set conversion library")
> + (description
> + "libiconv provides an implementation of the iconv function for
systems
> +that lack it. iconv is used to convert between character encodings in a
> +program. It supports a wide variety of different encodings.")
> + (home-page "http://www.gnu.org/software/libiconv/";)
> + (license lgpl3+)))
Maybe we should break this patch into two different ones, one for the
libiconv package description and one for the libiconv-if-needed. The
first will go to master and the second to core-updates. WDYT?
> +
> +(define* (libiconv-if-needed #:optional (target
(%current-target-system)))
> + (if (mingw-target? target)
> + `(("libiconv" ,libiconv))
> + '()))
> +
I am sorry for my ignorance but why is libiconv needed when targeting
mingw?
Because Microsoft does not implement iconv, and presumably this package needs
it.J' -- Avoid eavesdropping. Send strong encryted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
