Hello! Mathieu Lirzin <m...@gnu.org> skribis:
> l...@gnu.org (Ludovic Courtès) writes: [...] >>> + ;; xsltproc generates random ids when the source document >>> doesn't >>> + ;; provide them. This is making the build not reproducible. >>> + (substitute* "reposurgeon.xml" >> >> Eventually we should fix it in libxslt along these lines: >> >> https://bugzilla.gnome.org/show_bug.cgi?id=758148 >> >> Could you send an updated patch? > > After some digging, I have found that the generated IDs were based on > their node pointer address in the parse tree. So I have added an > additional patch which should be applied in the next release of libxslt. Awesome! (I realize that maybe we miscommunicated, given that “eventually” is a “false friend” compared to French.) > From aa709979cad4ac7d8b4ea8b34815e5ea7f4dde1d Mon Sep 17 00:00:00 2001 > From: Mathieu Lirzin <m...@gnu.org> > Date: Mon, 18 Apr 2016 23:21:42 +0200 > Subject: [PATCH 1/2] gnu: libxslt: Make generated documentation reproducible. > > * gnu/packages/patches/libxslt-generated-ids.patch: New file. > * gnu/packages/patches/libxslt-remove-date-timestamps.patch: Likewise. > * gnu/packages/xml.scm (libxslt)[source]: Use them. > * gnu-system.am (dist_patch_DATA): Add them. OK for ‘core-updates’. We’ll have to merge ‘master’ in ‘core-updates’ first, because of ‘search-patches’. You’re welcome to try it yourself if you want, but if in doubt (in case of merge conflicts), I can do it. > From 2e4a62093625709447bfb9e749b5bed50905669b Mon Sep 17 00:00:00 2001 > From: Mathieu Lirzin <m...@gnu.org> > Date: Fri, 8 Apr 2016 00:16:37 +0200 > Subject: [PATCH 2/2] gnu: Add reposurgeon. > > * gnu/packages/version-control.scm (reposurgeon): New variable. [...] > + (license (list bsd-2 bsd-3)))) I overlooked it before, but a comment above stating how the list is to be interpreted would be welcome. OK with this change. Thank you! Ludo’.