Mathieu Lirzin <m...@gnu.org> writes:
> * gnu/packages/linux.scm (powertop)[inputs]: Add kmod.
> [arguments]: Patch absolute file names. Before that launching powertop
> was failing because 'modprobe' was not found.
Looks good to me, but I have one thing to nitpick below.
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((kmod (assoc-ref inputs "kmod")))
> + (substitute* (find-files "src" ".*\\.cpp" )
> + (("/sbin/modprobe") (string-append kmod "/bin/modprobe"))
> + ;; These programs are only needed to calibrate, so using
> + ;; relative file names avoids adding extra inputs. When
> they
> + ;; are missing powertop gracefully handle it.
Should it not be “handles”?
> + (("/usr/bin/xset") "xset")
> + (("/usr/sbin/hciconfig") "hciconfig") ;XXX:not packaged yet
> + (("/usr/bin/hcitool") "hcitool")) ;XXX:not packaged yet
> + #t))))))
~~ Ricardo
