On Sun, Apr 17, 2016 at 10:50:55PM +0200, Hartmut Goebel wrote:
> * gnu/packages/python.scm: (python-maxminddb) (python2-maxminddb):
> New functions.
[...]
> + (arguments
> + ;; tests require a copy of the maxminddb which is not included
> + `(#:tests? #f))
Should the maxminddb be packaged so that we can run the tests?
> + (synopsis "Reader for the MaxMind DB format")
> + (description "This is a Python module for reading MaxMind DB files. The
> +module includes both a pure Python reader and an optional C extension.
> +
> +MaxMind DB is a binary file format that stores data indexed by IP address
> +subnets (IPv4 or IPv6).")
Can you explain to the reader what the purpose of the MaxMind DB is?
> + (properties `((python2-variant . ,(delay python2-maxminddb))))))
> +
> +(define-public python2-maxminddb
> + (let ((base (package-with-python2 (strip-python2-variant
> python-maxminddb))))
> + (package (inherit base)
> + (inputs
> + `(("python2-ipaddr" ,python2-ipaddr)
> + ,@(package-inputs base))))))
I see you already know to use the python2-variant system. Feel free to
move setuptools here if that works for python-maxminddb.
