Dear Leo, Thank you for taking the time to review my patch.
Leo Famulari writes: > On Wed, Mar 23, 2016 at 03:09:46PM +0100, Roel Janssen wrote: >> * gnu/packages/databases.scm (4store): New variable. >> * gnu/packages/patches/4store-fix-buildsystem.patch: New file. >> * gnu-system.am (dist_patch_DATA): Add patch file entry. > > [...] > >> +(define-public 4store >> + (let ((commit "c5a56d7c7504551a1f2fff6c16c4d9a440e4a317")) >> + (package >> + (name "4store") >> + (version (string-append "1.1.6-0." (string-take commit 7))) > > Why use this commit instead of the last release? I like especially these subtle changes/fixes: - run-time configurable HTTP log directory: commit 1725502cf01130ee80cf9b72249bbfc0f61f17fb - Fix for potential pointer arithmetic error: commit 6e2b4a70d4934484706a67b688ac30f3ca7baf98 The changes between the official release and this version are not that large. It probably isn't a problem to package the latest official release either, if that is preferable. >> Dear Guix, >> >> I would like to add 4store. The official website is currently offline, >> but there is an effort going on to get it back on line: >> https://github.com/garlik/4store/issues/137 >> >> Therefore, I would like to propose to keep the dead website link as this >> should sort itself out in time. > > I think this makes sense. Try to remember to follow up on the resolution > of that bug report :) Ok, I will try to remember that. :) Thanks again for your time. Kind regards, Roel Janssen
