On Mon, 28 Mar 2016 16:26:46 +0200 Ricardo Wurmus <rek...@elephly.net> wrote:
> Alex Kost <alez...@gmail.com> writes:
>
> > Kei Yamashita (2016-03-28 06:09 +0300) wrote:
> >
> >> On Sun, 27 Mar 2016 10:23:37 +0300
> >> Efraim Flashner <efr...@flashner.co.il> wrote:
> >>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, k...@openmailbox.org
> >>> wrote:
> > [...]
> >>> > + (arguments
> >>> > + '(#:configure-flags `("--without-alsa"
> >>> > "--without-jack")))
> >>>
> >>> In addition to Nil's comments, I was wondering about the configure
> >>> flags. Wouldn't it make sense to have either alsa or jack as an
> >>> input?
> >>
> >> Milkytracker works fine without it on my machine. I feel like it's
> >> a matter of allowing the user options or sticking to the minimal
> >> build.
> >
> > In my understanding (I may be wrong) our policy is to provide
> > full-featured software, so the features shouldn't be disabled
> > without a reason. Sometimes we add minimal packages (e.g.,
> > "bash-minimal", "cups-minimal") if they are needed, but this is not
> > such a case.
> >
> > So I think you should remove these --without-… flags. And thanks
> > for contributing!
>
> I agree. Also, JACK and ALSA are ubiquitous among Guix audio/music
> packages. When the programme comes with support for ALSA and JACK
> backends by default I think we should not disable it.
>
> ~~ Ricardo
>
Noted. New patch attached.
0001-Define-MilkyTracker-in-music.scm.patch
Description: Binary data
