On Thu, Mar 17, 2016 at 05:59:04PM -0400, Leo Famulari wrote: > On Thu, Mar 17, 2016 at 10:31:41PM +0100, Ricardo Wurmus wrote: > > > > Leo Famulari <l...@famulari.name> writes: > > > > >> > Does this actually work? I assumed that our “libarchive” package has > > >> > no > > >> > support for RAR archives. > > >> > > >> I don't know. The libarchive documentation in > > >> 'share/man/man5/libarchive-formats.5.gz' does list RAR as a supported > > >> format. > > > > > > Also, libarchive's 'include/archive.h' defines ARCHIVE_FORMAT_RAR and > > > declares archive_read_support_format_rar(). > > > > > > I don't have any .rar archives to test with, and I haven't seen one in > > > years. > > > > > > [...] > > > > > >> So, what should I do? Patch "rarfile" out of setup.py or package > > >> python-rarfile? > > > > > > Any feedback? I'd rather package python-rarfile. > > > > I was just curious. We can revisit this later when someone want to > > actually use python-rarfile to read rar files :) > > > > I have no objections to this patch. > > Okay, I will take another look at this patch series and probably push it > later today. >
A few of the patches list the home-page at http://github... and should be switched to https. Otherwise they look good to me. -- Efraim Flashner <efr...@flashner.co.il> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
