On Mon, Mar 07, 2016 at 12:42:03PM +0200, Efraim Flashner wrote: > * gnu/packages/boost.scm (mdds): Update to 1.1.0. > [home-page]: Update to new homepage. > (mdds-0.12.1): Keep for libreoffice.
While I wait for the build to finish, here is a superficial review. [...] > ;;; Copyright © 2014, 2015 Mark H Weaver <m...@netris.org> > ;;; Copyright © 2015 Andreas Enge <andr...@enge.fr> > -;;; Copyright © 2016 Eric Bavier <bav...@member.fsf.org> > ;;; Copyright © 2015 Ludovic Courtès <l...@gnu.org> > +;;; Copyright © 2016 Eric Bavier <bav...@member.fsf.org> > +;;; Copyright © 2016 Efraim Flashner <efr...@flashner.co.il> Is it possible to keep Eric's line in place, just to reduce noise in the logs? > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -107,21 +108,36 @@ across a broad spectrum of applications.") > (define-public mdds > (package > (name "mdds") > - (version "0.12.1") > + (version "1.1.0") > (source (origin > (method url-fetch) > (uri (string-append > - "http://kohei.us/files/mdds/src/mdds_"; version > ".tar.bz2")) > + "http://kohei.us/files/mdds/src/mdds-"; version > ".tar.bz2")) I can't figure out what the difference is between these lines... [...] > +;; Libreoffice needs mdds-0.12.1 to build, but its dependancies need > mdds-1.0+. > +;; Rather than use an external binary while building libreoffice, it's better > +;; to keep this version around until Libreoffice updates its dependancy. > +(define-public mdds-0.12.1 Could this be a private variable in libreoffice.scm? > + (package > + (inherit mdds) > + (version "0.12.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "http://kohei.us/files/mdds/src/mdds_"; version > ".tar.bz2")) > + (sha256 > + (base32 > + "0gg8mb9kxh3wggh7njj1gf90xy27p0yq2cw88wqar9hhg2fmwmi3")))))) > -- > 2.7.0 > >
