ren...@openmailbox.org (2016-02-15 21:35 +0300) wrote: > Hi, > > i attached gnome-backgrounds patch for review. > > Considerations: > a) I can't find the licenses CC-BY2 and CC-BY-SA2 in licenses.scm.
Then you are welcome to add them :-) See commit 12abc6e¹ for example. > b) Just found the home-page > "https://git.gnome.org/browse/gnome-backgrounds";, for the project. I think it's OK. There is probably no special home for backgrounds. [...] > +(define-public gnome-backgrounds > + (package > + (name "gnome-backgrounds") > + (version "3.18.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://gnome/sources/" name "/" > + (version-major+minor version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 (base32 ↑↑ should be shifted a bit > + "1fd7y8dh3iy88ayb8irgsihvssli6bzjzb5a6vfhi8qjbw70ymma")))) > + (build-system glib-or-gtk-build-system) > + (native-inputs > + `(("intltool" ,intltool))) > + (home-page "https://git.gnome.org/browse/gnome-backgrounds";) > + (synopsis "Background images for the GNOME desktop") > + (description > + "GNOME backgrounds package contains a collection of graphics files > +which can be used as backgrounds in the GNOME Desktop environment. > +Additionally, the package creates the proper framework and directory > structure > +so that you can add your own files to the collection.") > + (license (list license:gpl2+ > + ;; XXX: licensing also included: CC-BY2, CC-BY-SA2. > + license:cc-by-sa3.0)))) Overall the patch looks good to me, so if you are willing to add these missing licenses, I think we can commit 'gnome-backgrounds' afterwards. ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=12abc6e39548a55c2b6ba4113f9f1bde8d5d08e1 -- Alex
