Hi, Quoting Andreas Enge (2016-02-14 16:47:10) > On Sun, Feb 14, 2016 at 03:56:21PM +0100, Justus Winter wrote: > > this is my first package, please be nice ;) > > we always are :-)
:) > The package looks very nice, I only have a few minor comments. > > On Sun, Feb 14, 2016 at 03:56:22PM +0100, Justus Winter wrote: > > * gnu-system.am (dist_patch_DATA): Add new patch. > > * gnu/packages/bioinformatics.scm (genometools): New package. > > This should read "new variable". Ok. > > + #:phases (alist-delete 'configure %standard-phases))) > > You copy-pasted from an old-fashioned package here; I would suggest to use > the more modern modify-phases syntax. Ok. > > + (synopsis "Versatile open source genome analysis software") > > + (description > > + "The GenomeTools genome analysis system is a free collection of > > +bioinformatics tools (in the realm of genome informatics) combined > > +into a single binary named gt. It is based on a C library named > > +'libgenometools' which consists of several modules.") > > Ah, do not use the word "open source"! :-) Actually, we drop all occurrences > of "open source" and "free", since it is understood in the context of Guix. > Maybe the description could be a bit more, hm, descriptive? Instead of > giving the names of the commands, rather speak more about the functionality? Okay, I merely copied how the project described itself. > Thanks for your contribution, and welcome aboard! I'll send a follow-up. Thanks for the nit-picking, Justus
