Mathieu Lirzin <m...@gnu.org> skribis:
> * modules/shepherd/support.scm (user-dmddir): Rename to ...
> (%user-shepherd-dir): ... this. Honor XDG variables and use
> '~/.config/shepherd' as default value. All consumers changed.
> (mkdir-p): New procedure. Export it.
> (default-config-file): Use it.
> (verify-dir): Likewise.
Cool!
> +(define %user-shepherd-dir
> + ;; sheperd default directory if shepherd is run as a normal user.
^^^
Typo. :-)
I would rename the variable to ‘%user-config-dir’ or similar; I think
it’s putting the package name everywhere just makes it more difficult to
rename it. :-)
> + (string-append (or (getenv "XDG_CONFIG_HOME")
> + (string-append user-homedir "/.config"))
^^^
No tabs please!
Could you update shepherd.texi to so that it mentions the right
location, make sure XDG_CACHE_HOME is unset in AM_TESTS_ENVIRONMENT (or
similar), also add a test in basic.sh?
The test would essentially be done at the end of basic.sh, setting
XDG_CACHE_HOME to some temporary place and making sure that ‘shepherd’
loads the file.
Thank you! It’s great to see people have worked on to-do items while I
was away from keyboard! :-)
Ludo’.
