On 14/01/16 20:31, Ricardo Wurmus wrote:
Ben Woodcroft <b.woodcr...@uq.edu.au> writes:

On 11/01/16 07:17, Ludovic Courtès wrote:
Ben Woodcroft <b.woodcr...@uq.edu.au> skribis:

  From e3bad19a07d6a9fdf3045619232a24b77a1a5d12 Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <donttrust...@gmail.com>
Date: Wed, 6 Jan 2016 00:09:19 +1000
Subject: [PATCH 1/2] import: cran: Move beautify-description to utils module.

* guix/import/cran.scm (beautify-description): Move from here...
* guix/import/utils.scm: ... to here.
[...]

  From eb65d0ef0140ac2828b608c31ae19893861fea3a Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <donttrust...@gmail.com>
Date: Wed, 6 Jan 2016 00:17:36 +1000
Subject: [PATCH 2/2] import: gem: Beautify description field.

* guix/import/gem.scm (gem->guix-package): Use 'beautify-description'.
LGTM, thanks!
Pushed, ta.
This breaks two of the cran importer tests:

(test-equal "beautify-description: use double spacing"
   "This is a package.  It is great.  Trust me Mr.  Hendrix."
   ((@@ (guix import cran) beautify-description)
    "This is a package. It is great. Trust me Mr. Hendrix."))

(test-equal "beautify-description: transform fragment into sentence"
   "This package provides a function to establish world peace"
   ((@@ (guix import cran) beautify-description)
    "A function to establish world peace"))

How about moving these tests elsewhere?  (Or should they be removed?)
Ah, sorry. Should they be moved to a new file tests/import-utils? Why do you suggest that they should be removed?

ben

Reply via email to