Ludovic Courtès (2016-01-14 01:42 +0300) wrote: > Alex Kost <alez...@gmail.com> skribis: > >> Ludovic Courtès (2016-01-12 23:28 +0300) wrote: > > [...] > >>> I had overlooked it, but wouldn’t it be easier if patch #2 did: >>> >>> +(defvar guix-system-profile >>> + (concat guix-config-state-directory "/profiles/system/profile") >>> + "System profile.") >>> >>> ? >> Not really. >> >> Both "/var/guix/profiles/system" (which I called “system profile”) and >> "/var/guix/profiles/system/profile" (which I called “packages profile”) >> are needed. The former — for finding generations, and the latter — for >> finding packages. >> >> I actually need "/var/guix/profiles/system" in the first place, so if >> ‘guix-system-profile’ is not an appropriate name for this variable, it >> should be renamed (what name do you suggest?). > > Indeed, it’s confusing. I don’t have a better name to suggest, though.
BTW I've just noticed that '%system-profile' from (guix scripts system) has the same value, so "/var/guix/profiles/system" can be called a “system profile” after all I think ;-) >> And about name confusion: now I see that “profile” should be used only >> for a directory (symlink) with packages. But I always thought that a >> directory that has generations can also be named a “profile” (apparently >> cannot), especially taking into account ‘profile-generations’ procedure >> from (guix profiles) module: >> >> (profile-generations "/var/guix/profiles/system") >> >> That's why ^^^ I called "/var/guix/profiles/system" a system profile. > > Initially, I would have said that as long as FOO/manifest exists, FOO > can be called a profile. That’s the definition of a “profile” in the > sense of (guix profiles). > > Like a profile, /var/guix/profiles/system has generations, but unlike > “real profiles”, it is not created by ‘profile-derivation’. > > The solution in this patch looks good, after all! Great, thanks! -- Alex
