Ricardo Wurmus <rek...@elephly.net> skribis:
> From bf5cc4dcb73bd9e4c3de9f754e0e7d1c6f85337c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rek...@elephly.net>
> Date: Sat, 14 Nov 2015 17:18:02 +0100
> Subject: [PATCH 1/3] gnu: Add prefix to license imports in (gnu packages
> imagemagick).
>
> * gnu/packages/imagemagick.scm: Import (guix licenses) with prefix
> "license:".
OK.
> From 639471440868f6a9f87c4d3a2da8e917c9f55530 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rek...@elephly.net>
> Date: Sat, 14 Nov 2015 17:19:04 +0100
> Subject: [PATCH 2/3] gnu: Add GraphicsMagick.
>
> * gnu/packages/imagemagick.scm (graphicsmagick): New variable.
[...]
> +(define-public graphicsmagick
> + (package
> + (name "graphicsmagick")
Would it help to inherit from ‘imagemagick’?
> + (inputs
> + `(("graphviz" ,graphviz)
> + ("ghostscript" ,ghostscript)
> + ("gs-fonts" ,gs-fonts)
Or to use (package-inputs imagemagick) here?
Otherwise LGTM.
> From c5559fc76ce3e2f2d8d3eb12ed5e90e61c3b6f5d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rek...@elephly.net>
> Date: Sat, 14 Nov 2015 22:26:44 +0100
> Subject: [PATCH 3/3] gnu: Add Scribus.
>
> * gnu/packages/scribus.scm: New file
> * gnu/packages/patches/scribus-qobject.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES, dist_patch_DATA): Add them.
LGTM.
Nice job, thanks!
Ludo’.
