You've split these packages into separate commits on the wip-haskell-platform-7.10.2-a branch, but it's easier for me to comment here on all.
On Thu, 15 Oct 2015 14:21:15 +0200 Paul van der Walt <p...@denknerd.org> wrote: > * gnu/packages/haskell.scm (ghc-transformers-compat): New variable. > * gnu/packages/haskell.scm (ghc-exceptions): New variable. > * gnu/packages/haskell.scm (ghc-temporary): New variable. > * gnu/packages/haskell.scm (ghc-silently): New variable. > --- > gnu/packages/haskell.scm | 106 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 106 insertions(+) > > diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm > index 2585c81..adc9d82 100644 > --- a/gnu/packages/haskell.scm > +++ b/gnu/packages/haskell.scm [...] > +(define-public ghc-exceptions > + (package > + (name "ghc-exceptions") > + (version "0.8.0.2") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://hackage.haskell.org/package/exceptions/exceptions-"; > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "1x1bk1jf42k1gigiqqmkkh38z2ffhx8rsqiszdq3f94m2h6kw2h7")))) > + (build-system haskell-build-system) > + (arguments `(#:tests? #f)) > + (propagated-inputs > + `(("ghc-stm" ,ghc-stm) > + ("ghc-mtl" ,ghc-mtl) > + ("ghc-transformers-compat" ,ghc-transformers-compat))) > + (inputs > + `(("ghc-quickcheck" ,ghc-quickcheck))) Is this still required even with '#:tests? #f'? > + (home-page > + "http://github.com/ekmett/exceptions/";) > + (synopsis > + "Extensible optionally-pure exceptions") > + (description > + "Extensible optionally-pure exceptions") This is a fragment. In general, I notice that the formatting style varies a bit accross packages. Could you make sure that formatting, at least within gnu/packages/haskell.scm is mostly consistent? > + (license bsd-3))) > + > +(define-public ghc-temporary > + (package > + (name "ghc-temporary") > + (version "1.2.0.3") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://hackage.haskell.org/package/temporary/temporary-"; > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "0is67bmsjmbbw6wymhis8wyq9gax3sszm573p5719fx2c9z9r24a")))) > + (build-system haskell-build-system) > + (propagated-inputs `(("ghc-exceptions" ,ghc-exceptions))) > + (home-page > + "http://www.github.com/batterseapower/temporary";) > + (synopsis "Portable temporary file and directory support for Windows and > +Unix, based on code from Cabal") > + (description "The functions for creating temporary files and directories > +in the base library are quite limited. The unixutils package contains some > +good ones, but they aren't portable to Windows. This library just repackages > +the Cabal implementations of its own temporary file and folder functions so > +that you can use them without linking against Cabal or depending on it being > +installed.") > + (license bsd-3))) Again, we don't really need to mantion portability aspects. > + > +(define-public ghc-silently > + (package > + (name "ghc-silently") > + (version "1.2.5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://hackage.haskell.org/package/silently/silently-"; > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "0f9qm3f7y0hpxn6mddhhg51mm1r134qkvd2kr8r6192ka1ijbxnf")))) > + (build-system haskell-build-system) > + (arguments `(#:tests? #f)) ;; circular dependency with nanospec > + (inputs > + `(("ghc-temporary" ,ghc-temporary))) Is this required with '#:tests? #f', and if so, does it need to be propagated? > + (home-page "https://github.com/hspec/silently";) > + (synopsis > + "Prevent or capture writing to stdout and other handles.") I notice you fixed this in the wip branch. Thanks. > + (description > + "Prevent or capture writing to stdout and other handles.") Could you expand this so it's not a fragment? Thanks, `~Eric
