Hello and thanks for contributing! We prefer a separate patch per package, so please split this in two. Also was it intended to use "rws" as the Author name? If not, then please configure your git to use a name you want.
rws (2015-10-09 16:51 +0300) wrote: > * gnu/packages/wm.scm (bspwm): New package. > * gnu/packages/xdisorg.scm (sxhkd): New package. Our convention is to write "New variable" because the package recipes are just Guile variables. Also don't forget to add copyright lines for yourself to the beggining of wm.scm and xdisorg.scm: ;;; Copyright © 2015 ... [...] > + (synopsis "Simple X hotkey daemon") > + (description "sxhkd is a simple X hotkey daemon with a powerful and > +compact configuration syntax.") > + (license bsd-2))) Unlike the previous package, here it should be (license license:bsd-2). As you can see in (gnu packages xdisorg), (guix licenses) module is used with "#:prefix license:". The rest looks good to me. Could you send the updated patches? Thanks! -- Alex
