On Fri, Oct 9, 2015 at 8:23 AM, Ludovic Courtès <l...@gnu.org> wrote:
> "Thompson, David" <dthomps...@worcester.edu> skribis:
>
>> From 4be0c2bfd2e2e9a03d860cfb2ff92aa66cbfaa70 Mon Sep 17 00:00:00 2001
>> From: David Thompson <dthomps...@worcester.edu>
>> Date: Thu, 8 Oct 2015 21:23:09 -0400
>> Subject: [PATCH] scripts: environment: Use system* instead of system.
>>
>> This allows for direct program invokation without needing a shell to act
>> as a command interpreter.
>>
>> * guix/scripts/environment.scm (%default-shell): New variable.
>> (show-help): Adjust description. Remove '--exec' reference.
>> (%default-options): Use '%default-shell'.
>> (%options): Adjust '--exec' to run command via the default shell.
>> (parse-args): New procedure.
>> (guix-environment): Use 'parse-args'. Use 'system*' instead of
>> 'system'.
>> * guix/utils.scm (split): New procedure.
>> * tests/guix-environment.sh: Adjust tests to use '--' instead of
>> '--exec'.
>> * tests/utils.scm: Add tests for 'split'.
>> * doc/guix.texi ("Invoking guix environment"): Use new syntax. Remove
>> '--exec' documentation.
>
> Looks good to me. Could you just add ‘split’ in a separate commit?
>
>> (option '(#\E "exec") #t #f
>
> Add a “deprecated” comment.
>
>> # Make sure the exit value is preserved.
>> -if guix environment --ad-hoc guile-bootstrap --pure -E 'guile -c "(exit
>> 42)"'
>> +if guix environment --ad-hoc guile-bootstrap --pure -- guile -c '(exit 42)'
>
> Could you keep the example with -E, in addition to the new one, with a
> comment noting that this is the deprecated syntax? We’ll remove it when
> we finally remove -E.
>
> OK with these changes, thank you!
Thanks, fixed and pushed 2 commits.
- Dave
