On Mon 17 Aug 2015 10:43, Eric Bavier <ericbav...@openmailbox.org> writes:
> Hello Andy, > > Thanks for taking a closer look at this! > > On Mon, 17 Aug 2015 08:27:38 +0200 > Andy Wingo <wi...@igalia.com> wrote: > >> From db066d194d3b8359eddd0149234bfad29c11542d Mon Sep 17 00:00:00 2001 >> From: Andy Wingo <wi...@igalia.com> >> Date: Mon, 17 Aug 2015 08:26:07 +0200 >> Subject: [PATCH] gnu: Simplify LLVM build. >> >> * gnu/packages/llvm.scm (llvm): Simplify build. > > Could this perhaps be a bit more descriptive? It also doesn't > follow our standard. Maybe: > > gnu: llvm: Simplify build rpath handling. > > * gnu/packages/llvm.scm (llvm)[arguments]: Remove phases argument. > Add to configure-flags "-DCMAKE_SKIP_BUILD_RPATH=FALSE" and > "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE". > > `~Eric It could :) However I do not see how the change you mention would be indicated by the GCS, HACKING, or guix.texi. As per the GCS I think this falls under "simple changes". If Guix has additional requirements they should be indicated somewhere; did I miss the document? Cheers, Andy
