On 2015-08-05 09:51, Ricardo Wurmus wrote:
Hi Daniel,
as I wrote in a previous email the commit message should follow the
format shown in other messages. Take a look at the output of “git
log”.
Your patch adds a lot more than just “rage”. Also the copyright line
seems to be wrong. Did you really intend to submit a patch with copies
of “efl”, “elementary”, “evas-generic-loaders”, and
“emotion-generic-players” in addition to “rage”? If not, please do not
include them in your commit.
Please submit one separate patch for every single package definition
you
add.
I also think that “rage” better not be in its own module. How about
adding it to “enlightenment.scm” or “audio.scm” or similar?
Please also run “guix lint rage” to let Guix tell you a couple of
things
that can be improved about your package.
~~ Ricardo
Hi Ricardo and Guix,
you're right: Rage should in enlightenment.scm as terminology. So I add
it.
I ran 'guix lint enlightenment' and it's ok. The license format is
right.
Thanks for your patience :)
--
Daniel Pimentel (d4n1 3:)
