* Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> [2015-07-10 06:59]:
> Please add a comment to explain why the tests are disabled (no “check”
> target or failing tests?).

The tests are written in an m4 file which generates a configure script
that generates c main()'s that are compiled and run as tests against
rc.. there was a /bin/pwd in there that failed the test and I didn't
think a simple sed would be able to remove that part of the test.

I will include an explanation in my followup.

> The alignment and length of the lines makes it hard to read.  How
> about this instead:
[...]

Yea - I think emacs must not be loading the right scheme settings from
.dir-locals.el for some reason, any pointers to a "blessed config" or
style guide would be awesome.

Thanks for the review - the comments were very helpful and I'll be
updating the package shortly!

  //  codemac

Reply via email to