Ricardo Wurmus <rek...@elephly.net> skribis:
> Ludovic Courtès <l...@gnu.org> writes:
[...]
>>> + (native-search-paths
>>> + (list (search-path-specification
>>> + (variable "LV2_PATH")
>>> + (files '("lib/lv2")))))
>>
>> Shouldn’t it be in LV2 itself instead?
>
> I don’t know. LV2_PATH is used by LV2 hosts for the discovery of
> plugins. The “lv2” package itself does not provide any plugins; a host
> like Ardour has “lv2” as one of its inputs but does not provide any LV2
> plugins.
What matters is not whether ‘lv2’ provides plug-ins, but whether it is
the piece of code that honors $LV2_PATH (similar to GCC and $CPATH,
etc.)
> Currently, we only use (native-search-paths ...) suggesting “LV2_PATH”
> to be set for LV2 plugin packages. I would not mind moving this
> expression to the “lv2” package instead.
>
> Should I prepare another patch where this is removed from all package
> definitions and added to the “lv2” package instead?
That would be nice, yes. :-)
> From 444196dc501dad2ee793d5b1a20116fee799fb2f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rek...@elephly.net>
> Date: Sun, 14 Jun 2015 17:15:08 +0200
> Subject: [PATCH] gnu: Add Guitarix.
>
> * gnu/packages/audio.scm (guitarix): New variable.
[...]
> @@ -490,18 +492,17 @@ PS, and DAB+.")
> "mirror://sourceforge/faudiostream/faust-" version
> ".zip"))
> (sha256
> (base32
> - "068vl9536zn0j4pknwfcchzi90rx5pk64wbcbd67z32w0csx8xm1"))))
> + "068vl9536zn0j4pknwfcchzi90rx5pk64wbcbd67z32w0csx8xm1"))
> + (snippet
> + ;; Remove prebuilt library
> + '(delete-file
> "architecture/android/libs/armeabi-v7a/libfaust_dsp.so"))))
> (build-system gnu-build-system)
> (arguments
> `(#:make-flags (list (string-append "prefix=" (assoc-ref %outputs
> "out")))
> #:tests? #f
> #:phases
> (modify-phases %standard-phases
> - (add-after
> - 'unpack 'remove-prebuilt-library
> - (lambda _
> - (delete-file
> "architecture/android/libs/armeabi-v7a/libfaust_dsp.so")
> - #t))
> + ;; no "configure" script
> (delete 'configure))))
> (native-inputs
> `(("unzip" ,unzip)))
I guess this hunk should be in a separate patch.
OK for the rest.
Thank you!
Ludo’.
