Mathieu Lirzin <m...@openmailbox.org> skribis:
> do 'HACKING' copyright notices need to be added to the manual too?
Yes, please. (We may have to compress the copyright lines eventually
for the PS/PDF output.)
> From ccbbddb5d5335b3714a4e6204498f1fc24dca6ab Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <m...@openmailbox.org>
> Date: Tue, 9 Jun 2015 00:08:43 +0200
> Subject: [PATCH] doc: Merge 'HACKING' into Texinfo manual.
>
> * HACKING: Delete file.
> (Building from Git, The Perfect Setup, Coding Style, Submitting Patches):
> Move to ...
> * doc/guix.texi (Running Guix Before It Is Installed): Likewise.
> (Contributing): ... here.
> * README (Installation): Adapt to it.
> * configure.ac (DOT): Likewise.
> * Makefile.am (EXTRA_DIST): Likewise.
LGTM, but it removes a bit too much: The “Commit Access” section
vanished. Could you leave ‘HACKING’ with that section and a sentence
telling users to look at the “Contributing” section of the manual?
> +Please write commit logs in the ChangeLog format (@pxref{Change Logs,,,
> +Standards, GNU Coding Standards}); you can check the commit history for
^
Should be lowercase “standards” (the name of the Info file.)
> +examples.
> +
> +Before submitting a patch that adds or modifies a package definition,
> +please run @code{guix lint @var{package}}, where @var{package} is the
> +name of the new or modified package, and fix any errors it reports. In
^
Add: (@pxref{Invoking guix lint}).
> +addition, please make sure the package builds on your platform, using
> +@code{guix build @var{package}}. You may also want to check that
> +dependent package (if applicable) are not affected by the change;
> +@code{guix refresh --list-dependent @var{package}} will help you do
> +that.
^
Add: (@pxref{Invoking guix refresh}).
Could you send an updated patch?
Thanks for working on it!
Ludo’.
