Hi, Mathieu! Mathieu Lirzin <[email protected]> skribis:
> From eec846d938b35b7a286660257d4f878723ad9da7 Mon Sep 17 00:00:00 2001 > From: Mathieu Lirzin <[email protected]> > Date: Thu, 30 Apr 2015 22:26:57 +0200 > Subject: [PATCH] gnu: Add markdown. > > * gnu/packages/textutils.scm (markdown): New variable. LGTM! Some comments below: > + (use-modules (guix build utils)) > + (let ((source (assoc-ref %build-inputs "source")) > + (out (assoc-ref %outputs "out")) > + (unzip (string-append (assoc-ref %build-inputs "unzip") > + "/bin/unzip"))) > + (mkdir-p out) > + (with-directory-excursion out > + (system* unzip source) > + (mkdir "bin") > + (mkdir-p "share/doc") > + (rename-file "Markdown_1.0.1/Markdown.pl" "bin/markdown") I suspect you also need a call like: (patch-shebang "bin/markdown" (list (string-append (assoc-ref %build-inputs "perl") "/bin"))) so that the #! line in bin/markdown refers to the right Perl. > + (license license:non-copyleft))) ‘non-copyleft’ is a procedure so it should be: (license (license:non-copyleft "http://url-of-the-license-text";)) Could you send an updated patch? Thanks! Ludo’.
