Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> skribis: > "fastx-toolkit" installs three m4 files to "$out/share/aclocal", and > libgtextutils installs an empty "$out/share/aclocal" directoy. I > reported this upstream, but I did not add a phase to remove these files, > because I think it's not a big deal. Is this okay or should I modify > the sources to avoid installing these files?
What’s wrong with these files? It looks fine to me, and it’s the standard directory for Autoconf macros. So no problem IMO. :-) > From 673f316fd41b0d0d7679a7a69ed4755923873653 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> > Date: Tue, 14 Apr 2015 16:35:30 +0200 > Subject: [PATCH 1/2] gnu: Add libgtextutils. > > * gnu/packages/textutils.scm (libgtextutils): New variable. [...] > + '(#:phases > + (alist-cons-after > + 'unpack 'autoreconf > + (lambda _ (zero? (system* "autoreconf" "-vif"))) So there’s no ‘make dist’ tarball I suppose? > + (home-page "http://hannonlab.cshl.edu/fastx_toolkit";) Maybe the github.com URL? > + (synopsis "Gordon's text utils library") > + (description > + "libgtextutils is a text utilities library Not satisfying but apparently there’s nothing in the REAME nor in the doc so we’ll live with it. > From 1d386b93064eb839e0156938ac38919daa654839 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> > Date: Tue, 14 Apr 2015 16:36:30 +0200 > Subject: [PATCH 2/2] gnu: Add FASTX Toolkit. > > * gnu/packages/bioinformatics.scm (fastx-toolkit): New variable. LGTM! Thanks, Ludo’.
