Tomas Cech <sleep_wal...@suse.cz> skribis: > commit 87bafa07ae68084819bb2648bd1042c354d11317 > Author: Tomáš Čech <sleep_wal...@gnu.org> > Date: Wed Mar 18 08:57:50 2015 +0100 > > gnu: Add agg. > > * gnu/packages/graphics.scm (agg): New variable. > * gnu/packages/patches/agg-am_c_prototype.patch: New file. > * gnu-system.am (dist_patch_DATA): Add it.
[...] > +++ b/gnu/packages/patches/agg-am_c_prototype.patch > @@ -0,0 +1,10 @@ > +--- a/configure.in 2015-03-15 18:59:12.557417149 +0100 > ++++ b/configure.in 2015-03-15 18:59:29.273416518 +0100 Patches must have a comment at the beginning to explain what they do, why, and what the upstream status is. Please pay more attention to these rules before pushing. In general, I would recommend that you wait for some review before pushing. (This is sometimes slow, but hopefully others will help reduce latency, hint hint! ;-)) > +@@ -8,7 +8,6 @@ > + AC_PROG_CC > + AC_PROG_CXX > + AC_ISC_POSIX > +-AM_C_PROTOTYPES > + if test "x$U" != "x"; then > + AC_MSG_ERROR(Compiler not ANSI compliant) > + fi It is best to avoid modifying .ac or .am files because that requires adding a dependency on the autotools. What problem does this patch solve? I’m confident this can be worked around without modifying the .ac file, for instance by passing the right ac_cv_ variable as a ‘configure’ argument. Thanks, Ludo’.
