taylanbayi...@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:
>>> + ("libxshmfence" ,libxshmfence)
>>
>> Please add a margin comment explaining the reason.
>
> It's in the "Requires.private" field of the gl.pc pkg-config file. The
> same seems to be the case for other packages in the propagated-inputs
> list. Should it be explained for all of them?..
I just noticed that there's more packages in that .pc section which are
in the inputs but not propagated inputs. Should I propagate them all?
Here is the whole .pc field, pretty-printed:
Requires.private:
libdrm >= 2.4.38
x11
xext
xdamage
xfixes
x11-xcb
xcb
xcb-glx >= 1.8.1
xcb-dri2 >= 1.8
xcb-dri3
xcb-present
xcb-sync
xshmfence >= 1.1
xxf86vm
And here are the propagated and normal inputs prior to my patch:
(propagated-inputs
`(("glproto" ,glproto)
("libdrm" ,libdrm)
("libx11" ,libx11)
("libxdamage" ,libxdamage)
("libxxf86vm" ,libxxf86vm)))
(inputs
`(("udev" ,eudev)
("dri2proto" ,dri2proto)
("dri3proto" ,dri3proto)
("libxshmfence" ,libxshmfence)
("presentproto" ,presentproto)
("expat" ,expat)
("libxfixes" ,libxfixes)
("libxml2" ,libxml2)
;; TODO: Add 'libva'
;; TODO: Add 'libxml2-python' for OpenGL ES 1.1 and 2.0 support
("makedepend" ,makedepend)
("s2tc" ,s2tc)))
So I think libxshmfence and libxfixes should be propagated, right?
Taylan
