Ludovic Courtès <l...@gnu.org> writes: > 宋文武 <iyzs...@gmail.com> skribis: > >> * gnu/services/xorg.scm (xinitrc)[builder]: Don't check the existence >> of COMMAND. Only run ~/.xsession when it exists. > > [...] > >> + (let* ((home (getenv "HOME")) >> + (xsession-file (string-append home "/.xsession")) >> + (session (match (command-line) >> + ((_ x) x) >> + (_ #$fallback-session)))) > > Could you align the right-hand sides of the ‘let*’? > >> + (if (file-exists? xsession-file) >> + ;; Run ~/.xsession when it exists. >> + (exec-from-login-shell xsession-file) > > This will fail if ~/.xsession is not executable. It could use > ‘executable-file?’ from (guix build utils), but OTOH it may be better to > just fail in this case since it’s most likely a user error. I'm OK to fail here.
Pushed, thanks for review! > > Thoughts? > > Thanks, > Ludo’.
