Tomáš Čech <sleep_wal...@suse.cz> skribis:
> * gnu/packages/enlightenment.scm: New file
> * gnu/packages/enlightenment.scm (efl): New variable.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> + (propagated-inputs
> + ; all these inputs are in package config files in section
> + ; Require.private
Please use two semicolons for comments like this one. Capitalize
sentences and add a period at the end.
> + (alist-cons-before
> + 'configure 'patch-config-files
> + (lambda _
> + (substitute* "po/Makefile.in.in"
> + (("/bin/sh") (which "bash"))))
I persist to think that this is not needed, is it? If not, please
remove it.
> + (description
> + "Enlightenment Foundation Libraries is set of libraries developed
> +for Enlightenment, but is used for more applications because it is resource
> +friendly, energy efficient and good looking. It consists of:
> +
> + * Eina - defining data types and low level abstractions
> + * Eo - generic object concept for EFL
> + * Eet - binary data parser and serializer
> + * Evas - canvas library
> + * Ecore - abstraction to operating system
> + * Embryo - script engine
> + * Escape - Playstation portability layer
> + * Evil - Microsoft Windows portability layer
> + * Eio - library for asynchronous input/output
> + * Eldbus - DBus integration
> + * Efreet - support for Freedesktop.org standards
> + * Eeze - hardware interface
> + * EPhysics - integration of physics engine
> + * Edje - UI layout library, themes support
> + * Emotion - multimedia integration
> + * Ethumb - image thumbnail support")
You’ll hate me for saying that ;-) but please make it just a plain
paragraph: the UIs may reformat the paragraph to their without caring
for the bullet list.
The text probably doesn’t need to be exhaustive, just to list some of
the main functionality.
> + (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ;
> different parts under different licenses
Line too long.
OK to push with these changes.
Thanks!
Ludo’.
