Hi,
I'm a little busy for now, but i'll get to this soon. Thanks for your
comments!
On 2015-02-27 at 17:13, quoth Mark H Weaver:
>> Paul van der Walt <p...@denknerd.org> writes:
> [...]
>>> + (arguments
>>> + '(#:configure-flags
>>> + '("BOOST_LIB_SUFFIX=")
>>> + #:phases
>>> + (alist-cons-after
>>> + 'unpack 'autogen
>>> + (lambda _
>>> + (substitute* "autogen.sh"
>>> + (("/bin/sh") (which "bash")))
>>
>> Is "autogen.sh" not executable? If it starts with a shebang, Guix
>> should patch the file appropriately.
>
> The problem here is that this 'autogen' phase is run before the
> 'patch-source-shebangs' phase, at my suggestion. It has to be that way,
> because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
> be run on the files created by 'autogen.sh'.
This is the case. Is this therefore the cleanest way to do it?
>>> + (setenv "NOCONFIGURE" "true")
>>> + (zero? (system* "bash" "autogen.sh")))
>>
>> If its executable, you can say:
>>
>> (zero? (system* "./autogen.sh"))
>
> Yes, after the 'substitute*' above, this should presumably work. My
> guess is that Paul added the "bash" here before he realized that he
> also needed the 'substitute*'.
This is what happened. I'll modify that. One last question:
>> From e1382a9df3e7df94e794df8aa247920b7e28c0c6 Mon Sep 17 00:00:00 2001
>> From: Paul van der Walt <p...@denknerd.org>
>> ...
>
> Could you please add a copyright line for yourself at the top of this
> file?
Are these from lines not enough? My previous patch which i generated the
same way was accepted.
Bye! Have good weekends!
p.
