Ludovic Courtès writes:
> Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> skribis:
>
>> + (inputs
>> + `(("atlas" ,atlas) ; --with-blas
>> + ("bzip2" ,bzip2)
>
> Unless used for libbz2, move it to ‘native-inputs’.
>
>> + ("perl" ,perl)
>
> Likewise.
>
>> + ("texlive" ,texlive) ; needed to make vignettes
>> + ("texinfo" ,texinfo) ; for building HTML manuals
>> + ("which" ,which) ; for tests/Examples/base-Ex.R
>
> These 3 are definitely native inputs.
>
>> + ("xz" ,xz)
>
> Most likely native input.
I fixed the inputs vs native-inputs issues. Sorry about that.
>> + (home-page "http://www.r-project.org/";)
>> + (synopsis "Language and environment for statistical computing and
>> graphics")
>> + (description
>> + "R is a language and environment for statistical computing and
>> graphics.
>> +R is similar to the award-winning S system, which was developed at Bell
>
> ‘guix lint’ should propose you a synopsis and description; could you use
> them?
>
> The rest LGTM.
I've taken over the description and synopsis suggested by "guix lint"
and pushed the patch.
Thanks again for the review!
~~ Ricardo
