Ludovic Courtès writes: > Ricardo Wurmus <rek...@elephly.net> skribis: > >> Unlike the Python build system, however, there is a configure phase, and >> not everything important happens during the install phase. > > OK. Did you find it more appropriate to extend ‘gnu-build-system’ > rather than ‘python-build-system’?
The way I see it the waf-build-system is a descendant of the gnu-build-system in that it has the same phases; it only uses a different tool (namely the waf script). The python-build-system on the other hand concentrates everything in the install "phase". The waf-build-system looks similar to the python-build-system only because the waf script needs to be run with a python interpreter, and it could be either version 2 or 3. This is why I extended the gnu-build-system (as a "parent") and imported the default-python procedures from python-build-system (as a "cousin"). Does this make any sense? > >> From adc52a74fb12943fd77c97bf75a2092e839f9024 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus <rek...@elephly.net> >> Date: Wed, 28 Jan 2015 22:39:03 +0100 >> Subject: [PATCH] Add 'waf-build-system'. >> >> * guix/build-system/waf.scm, guix/build/waf-build-system.scm: New files. >> * Makefile.am (MODULES): Add them. > > Could you add a few lines to guix.texi, under “Build Systems”? Other > than that this looks good to me. I'll try and send an updated patch. ~~ Ricardo
