Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> skribis: > There are a couple of problems with this package, one of which is that > the test suite is failing for some reason. I have not been able to > figure out why the "cupsFileFind" test fails, so I disabled the tests.
OK. Do you have any more details from the test suite log? > I'm also not sure if creating two outputs "out" and "include" is > correct. To build OpenJDK with IcedTea I need to have both the library > output and the include files and after splitting the outputs this worked > fine. The reason for splitting would be if it turns out that the include directory takes a fair amount of space that is not needed in many cases. If that’s the case, then splitting makes sense. That may well be the case: what’s the side of each of these outputs? If it’s just that it happens to fix OpenJDK as a side effect, that’s not a good reason. :-) > Finally, I have not actually tried to use CUPS at all, because I only > really need the libs and headers to build OpenJDK. OK but that’ll be useful eventually to get Evince and friends to print correctly. > + (license license:gpl2+))) Isn’t it GPLv2-only? The rest looks good to me. Thanks, Ludo’.
